#1888 use StringBuilderWriter instead of StringWriter in performance hotspot to reduce locking#1889
Conversation
…performance hotspot to reduce locking
| import java.io.Writer; | ||
|
|
||
| /** | ||
| * <p> |
There was a problem hiding this comment.
Like Groovy, I kept the copyright notice and JavaDoc intact but removed the dependency on IOUtils.
There was a problem hiding this comment.
Build is KO due to copyright missing I guess
There was a problem hiding this comment.
@laurentschoelens yes - how shall I handle this? is it possible to add a jaxb-ri copyright to a class copied from another project? I am not a lawyer...
There was a problem hiding this comment.
Nevermind, I found the copyright-exclude file...
There was a problem hiding this comment.
That’s for code which either went through legal or is non-source file. This does not satisfy any of those conditions and likely breaks existing project’s license.
lukasj
left a comment
lukasj
left a comment
There was a problem hiding this comment.
Submit an implementation which uses project’s license
Do we need to submit internal class which is not a copy of StringBuilderWriter class (so we could have it under correct license) but does the same job ? |
|
yes, basically what needs to be done is known, so just go ahead and implement it from scratch, write own javadoc, give it project's license - EDL - and submit a PR. btw if I got it right, Apache license allows the license change, so... |
3 participants
closes #1888